fix(llamaindex): instrument agents & tools #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirga
force-pushed
the
llamaindex-agents
branch
3 times, most recently
from
eb6bc9a to
22b3916
Compare
nirga
force-pushed
the
llamaindex-agents
branch
from
22b3916 to
f1032bf
Compare
paolorechia
approved these changes
Feb 27, 2024
...strumentation-llamaindex/opentelemetry/instrumentation/llamaindex/base_agent_instrumentor.py
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,62 @@ | |||
| from importlib.metadata import version as package_version, PackageNotFoundError | |||
There was a problem hiding this comment.
🙃 (NIT) There is a lot of duplication here. Maybe it could be refactored sometime.
There was a problem hiding this comment.
Yeah I know :/ I need to refactor this
|
Just noticed there's a failing test on 3.11 because of pydantic |
nirga
force-pushed
the
llamaindex-agents
branch
from
13c42b9 to
97d37ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.