fix(openai): Fix with_raw_response redirect crashing span
#536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonybaloney
changed the title
with_raw_response redirect crashing spanwith_raw_response redirect crashing span
…hich has the .parse() method and then recursively calling the result so that span attributes are still captured
tonybaloney
commented
Feb 27, 2024
| @@ -9,7 +9,7 @@ def test_chat_streaming(exporter, openai_client, vcr): | |||
| stream=True, | |||
| ) | |||
|
|
|||
| for part in response: | |||
| for _ in response: | |||
There was a problem hiding this comment.
This has nothing to do with the mentioned bug, it was just bugging me :-)
|
Liked the TDD 😀 |
nirga
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535
feat(instrumentation): ...orfix(instrumentation): ....