feat(instrumentation-anthropic): Support for OpenTelemetry metrics for Anthropic #764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #251
Hi,
I referred a lot to #369 while working on this.
I added
token_counter
choice_counter
duration_histogram
exception_counter
metrics for all
sync
/async
completion
/messages
/streaming messages
methods.
There are a few
TODO
s, I'd appreciate it if you check it out.choice_counter
of streaming response, I just added length ofevents
bc each of it hasfinish_reason
, but I'm still not sure if it's appropriate. (opentelemetry/instrumentation/anthropic/streaming.py).exception_metric
of streaming responses. I think I should add mocks and trigger exception in the middle of yielding, but I'm just wondering if there's better way. (tests/test_completion.py)Any comments and discussions will be appreciated!
feat(instrumentation): ...
orfix(instrumentation): ...
.