Drop TypeScript support for <= 4.7 #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlfurniss
reviewed
Mar 15, 2023
| - 4.4 | ||
| - 4.5 | ||
| - 4.6 | ||
| - 4.7 |
There was a problem hiding this comment.
Your PR says less than or equal to 4.7, did you mean to remove this?
|
Note that it's intentionally left open to interpretation in that RFC and at https://semver-ts.org: what "old" constitutes is going to be a function of the rest of the general ecosystem. We will generally want to track similar timeframes as our Node and Ember version support, but that's intentionally vague. The key point is to enable "laddering up", as this does with the description (and the change I just pushed). |
chriskrycho
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note sure how what we should consider "old" TypeScript versions.
couldn't get advise in https://rfcs.emberjs.com/id/0724-road-to-typescript/#semantic-versioning-and-supported-typescript-versions either