Skip to content
This repository was archived by the owner on Aug 15, 2023. It is now read-only.

fix(tktrex): tktrex extension data-donation size check #373

Merged
merged 19 commits into from
Feb 14, 2022

Conversation

ascariandrea
Copy link
Collaborator

No description provided.

@ascariandrea ascariandrea marked this pull request as draft February 8, 2022 18:16
@ascariandrea ascariandrea force-pushed the fix/shared-extension branch 3 times, most recently from 94c6285 to 8c03dcc Compare February 9, 2022 15:03
@vecna
Copy link
Member

vecna commented Feb 10, 2022

you keep it in WiP to add #382 or can I proceed with testing? thanks!

@ascariandrea
Copy link
Collaborator Author

I didn't have the chance to continue on this cause I've worked on YCAI the last days, but I can finalize it now

@ascariandrea ascariandrea marked this pull request as ready for review February 10, 2022 15:57
@ascariandrea
Copy link
Collaborator Author

@vecna ready to test 🧷

@ascariandrea ascariandrea requested a review from vecna February 10, 2022 15:58
@vecna
Copy link
Member

vecna commented Feb 11, 2022

The extension works but seems it is sending something too much:

  parsers:description Retval is { description: '#foryourpage' } +5ms
  parsers:hashtags No hashtags for previous.nature { type: 'video', videoId: undefined, authorId: 'search' } +39ms
  parsers:numbers No numbers in previous.nature { type: 'video', videoId: undefined, authorId: 'search' } +39ms
  parsers:stitch No stitch for previous.nature { type: 'video', videoId: undefined, authorId: 'search' } +40ms
  parsers:author No hashtag for previous.nature { type: 'video', videoId: undefined, authorId: 'search' } +39ms

this is from the parser. but don't worry, I'll debug this part of the backend.

@vecna
Copy link
Member

vecna commented Feb 11, 2022

what I don't like is that all the messages/debug now looks from the same line:
image
and how I can control the verbosity of this log? because if I remove the "verbose" option, every log disappears

@vecna
Copy link
Member

vecna commented Feb 11, 2022

this is something that shouldn't happen:
image
only if there is an increment a new packet should be sent, but by debugging the background window you can see the events are duplicates

@vecna
Copy link
Member

vecna commented Feb 11, 2022

but beside the problems above, the patch works and the backend was ready for it:
image
video get accumulated by multiple of 12

@ascariandrea
Copy link
Collaborator Author

I fixed the duplicated videos in the POST /events request and debounced the mutation observer's callbacks to avoid useless run of the handlers.

To manage the log output you can use the filter bar to show only the log you want to see, or you can enable/disable then with the DEBUG variable used in yarn tk:ext watch (or yarn tk:ext build)

@vecna
Copy link
Member

vecna commented Feb 12, 2022

I can't understand which part of YCAI should be preserved, so I can't fix these conflicts...

@ascariandrea ascariandrea linked an issue Feb 14, 2022 that may be closed by this pull request
@ascariandrea ascariandrea merged commit eb7af3a into daily Feb 14, 2022
@ascariandrea ascariandrea deleted the fix/shared-extension branch February 14, 2022 11:40
ascariandrea added a commit that referenced this pull request Feb 14, 2022
* refactor(ycai): moved providers in shared package

* fix(tktrex): data donation for tktrex

* chore(tktrex): add tktrex extension to releases

Co-authored-by: Claudio <claudio@syrianarchive.org>
ascariandrea added a commit that referenced this pull request Feb 15, 2022
* refactor(ycai): moved providers in shared package

* fix(tktrex): data donation for tktrex

* chore(tktrex): add tktrex extension to releases

Co-authored-by: Claudio <claudio@syrianarchive.org>
ascariandrea added a commit that referenced this pull request Feb 16, 2022
* refactor(ycai): moved providers in shared package

* fix(tktrex): data donation for tktrex

* chore(tktrex): add tktrex extension to releases

Co-authored-by: Claudio <claudio@syrianarchive.org>
ascariandrea added a commit that referenced this pull request Feb 16, 2022
chore(guardoni): dist-all shell script (#324)
chore(ycai): remove 'moment' dep (#356)
chore(guardoni): removed moment dep (#355)
fix(ycai): return total contributions in get creator stats api (#358)
chore(workspace): tsc diagnostics report (#357)
chore(yttrex): removed outdated create-react-class dep (#360)
chore(workspace): deps upgrade and "chai", "mocha", "immutability-hel…
chore(shared): fix DOTENV_CONFIG_PATH resolution in webpack config (#359
fix: guardoni cli and electron build (#371)
fix(guardoni): removed unused imports from cli file
chore(workspace): fix last version bump 2.2.2
ci: added 'preReleaseId' option to beta release
feat(backend): implemented originalHref into experiment CSV #384 (#385)
fix: guardoni electron dmg build and default paths (#387)
feat(ycai): gem collection (#345)
fix(backend): memory safer function for experiment extension (#393)
fix(ycai): gem card icons center alignment
fix(tktrex): tktrex extension data-donation size check (#373)
chore: pass env vars to ycai build on after release bump hook
fix: webpack extension outdir path
ci(ycai): release with proper env when merged in master [skip ci]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor page size increasing in tktrex extension
2 participants