Skip to content
This repository was archived by the owner on Aug 15, 2023. It is now read-only.

fix(shared): add errors UI for extension #830

Merged
merged 11 commits into from
Dec 12, 2022
Merged

fix(shared): add errors UI for extension #830

merged 11 commits into from
Dec 12, 2022

Conversation

ascariandrea
Copy link
Collaborator

Summary

This solves the issue #580 by using the ErrorModal component.

Changelog

[fix:shared] add errors UI for extension

Test Plan

yarn tk:ext watch
# open tiktok.com in the browser
# should see the error (for missing connection with the server)

@ascariandrea ascariandrea marked this pull request as draft December 1, 2022 15:47
@ascariandrea ascariandrea marked this pull request as ready for review December 1, 2022 17:07
@ascariandrea ascariandrea requested a review from rekoke December 1, 2022 17:07
@ascariandrea ascariandrea merged commit 2732651 into daily Dec 12, 2022
@ascariandrea ascariandrea deleted the fix/show-error-ui branch December 12, 2022 17:14
@ascariandrea ascariandrea mentioned this pull request Dec 12, 2022
Closed
ascariandrea added a commit that referenced this pull request Jan 19, 2023
@ascariandrea @rekoke
fix(shared): add errors UI for extension (#830)
c908032 
Co-authored-by: koke <rekoke92@gmail.com>
ascariandrea added a commit that referenced this pull request Jan 20, 2023
@ascariandrea @rekoke
fix(shared): add errors UI for extension (#830)
d77c3d7 
Co-authored-by: koke <rekoke92@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rekoke rekoke rekoke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascariandrea @rekoke