Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded CFDP test script with additional test cases #18

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

DavidEdell
Copy link
Contributor

split into discete unittest test cases for easier reporting. Note: Several cases have been disabled pending additional bugfixes.

  • BUG1: Previously mentioned issue with juicer prevents sending transfer commands to CFE CF. There are now disabled test cases to exercise this case
  • BUG2: Large (ie: 64k) transfers are still failing in most combinations. Ironically the condition above (which I can test only by bypassing our ros commanding interface) is the transfer path that works most reliably (after the debugging I did previously).
    • Duplicating my QOS fix to the bridges subscriptions had no observable effect
    • I suspect there may still be an issue on the cfe SBN side, but the main issue seems to be on the ROS side
    • The QoS flag I found for subscribers looks to also apply to publishers, so it seems possible that may be the other culprit
      • I haven't had time to verify with wireshark where the packets are being dropped, but I'm currently suspecting the ROS QoS may be dropping some packets when publishing (on all ends) when a large number of messages arrive at once with the same topic (ie: the cfdp pdus).
    • Note: Even in ACK mode, large files are corrupted on receipt. CFDP does report checksum failure - presumably it reaches some limit in retries
  • BUG3: Very large binary files seem to cause an exception in cfdp_wrapper. I suspect this is a bug in the upstream cfdp library, but haven't had a chance to investigate, and I hadn't seen this previously. The 64k tests I added in the unit test are apparently not large enough to trigger this error. It's possible there's a mismatch in maximum PDU size

…ete unittest test cases for easier reporting. Note: Several cases have been disabled pending additional bugfixes.
@DavidEdell DavidEdell requested review from ana-GT and andrewmatic June 10, 2024 14:42
…truncation errors. Note: 8k value was chosen arbitrarily and should be refined to match corresponding buffer sizes in cfe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant