Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPO-419: Adds automated model build workflow #106

Merged
merged 9 commits into from
Oct 22, 2024

Conversation

willfish
Copy link
Contributor

@willfish willfish commented Sep 23, 2024

Jira link

FPO-419

What?

I have added/removed/altered:

  • Added a workflow to automate releasing a new model on the 1st and 15th of each month
  • Added a script to create the PR and bump the version
  • Added a script to install gh cli since there's no official orb to do this
  • When validation of the model fails, make sure to close the PR, delete the branch and exit
  • When the validation succeeds and after post-deployment tests merge the PR to enable automated production deployments

Why?

I am doing this because:

  • This enables us to continually keep search references, commodities, etc, dynamically updated

AC

  • Models are successfully being generated on a schedule
  • Automated PRs are closed off (either merged/closed and deleted) when we know the result

@willfish willfish force-pushed the FPO-419-automated-model-runs branch from bb75f07 to 3cc92dc Compare September 23, 2024 09:58
@willfish willfish force-pushed the FPO-419-automated-model-runs branch from 5bac427 to fa28e2b Compare September 25, 2024 14:12
@willfish willfish force-pushed the FPO-419-automated-model-runs branch from fa28e2b to 50a7ea4 Compare September 25, 2024 14:17
@willfish willfish force-pushed the FPO-419-automated-model-runs branch from 73b2c72 to 4adb509 Compare September 27, 2024 14:30
@amberstarlight
Copy link
Member

Getting this running in CI and it began running in an infinite loop 🥴 debugging the CircleCi workflow.

@amberstarlight
Copy link
Member

Re-adding the job triggers resolved that. However there's some Python errors (looks unrelated to this PR) that I want to clear out before merging.

@amberstarlight
Copy link
Member

The import error (from cached_download, from sentence-transformers) is resolved when bumping sentence-transformers upwards of v2.3.0 - see below issue.

UKPLab/sentence-transformers#3001 (comment)

@amberstarlight amberstarlight merged commit c80ff86 into main Oct 22, 2024
14 checks passed
@amberstarlight amberstarlight deleted the FPO-419-automated-model-runs branch October 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants