Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with TabClosing event #2

Closed
gmattis opened this issue Apr 4, 2019 · 3 comments
Closed

Issue with TabClosing event #2

gmattis opened this issue Apr 4, 2019 · 3 comments

Comments

@gmattis
Copy link

gmattis commented Apr 4, 2019

I'm currently using your custom control for a private software (and it is perfect by the way), but I ran into an issue dealing with the TabClosing event.
This event is currently raised after the tab is closed, instead of being raised before the tab is closed. It seems like moving the if (this.TabClosing != null) statement at the top of the OnTabClosing method (in TabControlExtra.cs) solves the issue. May you make a commit solving the problem? Thank you for your great work!
@rlktradewright
Copy link
Contributor

Ok, I'll look into it. Not immediately though...

@rlktradewright
Copy link
Contributor

You're right, there's definitely a fault there, well spotted! I'll try to commit a fix over the weekend.

rlktradewright added a commit that referenced this issue Apr 8, 2019
@rlktradewright
Fix bug #2 TabClosed fires before TabClosing
244eec6
@gmattis
Copy link
Author

gmattis commented Apr 9, 2019

Thank you!

@gmattis gmattis closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rlktradewright @gmattis