Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trading pair details page refresh (part 1) #642

Closed
Tracked by #636
kenkunz opened this issue Dec 14, 2023 · 0 comments · Fixed by #766
Closed
Tracked by #636

Trading pair details page refresh (part 1) #642

kenkunz opened this issue Dec 14, 2023 · 0 comments · Fixed by #766
Assignees
Labels
enhancement New feature or request priority: P1 An important issue that must be fixed before the next release, but does nto require immediate focus. size: M An ordinary task that can be completed in a few days or in a week

Comments

@kenkunz
Copy link
Contributor

kenkunz commented Dec 14, 2023

See epic #636

Goal

As an investor, I want the trading pair details page to include updated stats, labels and layout improvements, so that I can better compare different trading pairs.

Acceptance criteria

  1. ✅ add swap fee % to header for all pairs (currently only shown on Uniswap V3 pairs)
    • update "Swap fee" label to "Trading fee"
  2. ✅ add blockchain logo to subtitle
  3. ✅ remove liquidity metric (now that TVL is available on all pairs)
  4. ✅ remove Uniswap v3 beta warning
  5. ✅ move buy/sell buttons to single "swap" header button
  6. ✅ remove blockchain explorer button (same as smart contract address)
  7. ✅ Move "API and historical data" and "Copy Python identifier" buttons up to tighten up layout.
    • removed "API and historical data" button as the page is no longer needed

TODO: Separate ticket(s)

To manage scope of this ticket, the below items should move moved to separate tickets:

  1. consider making above buttons open a modal dialog instead of new page (merge "Copy Python…" into dialog) not needed
  2. update HUD to match newer style used on strategy charts (tooltip follows mouse; full labels). NOTE: this is a departure from TradingView™ style HUD. de-scoped – see Improve trading pair chart HUD style #785
  3. use consistent (non-US) date format (e.g., 2023-09-23) addressed in another ticket
  4. consider reducing height of TVL chart and making it a "panel" of price chart rather than separate (linked) chart de-scoped – see Improve trading pairs linked TVL chart #786
  5. right-align data cells in time period summary (numeric values) see Trading pair details page refresh (part 2) #776
  6. replace liquidity values with TVL (not currently available in API) see Replace liquidity values with TVL on pair details time period summary #787
  7. consider rethinking / replacing this section (relies on expensive API calls; hidden below the fold) after feedback, decided to keep this section as-is

Screenshot w/annotations

@kenkunz kenkunz added enhancement New feature or request priority: P1 An important issue that must be fixed before the next release, but does nto require immediate focus. size: M An ordinary task that can be completed in a few days or in a week labels Dec 14, 2023
@kenkunz kenkunz self-assigned this Dec 14, 2023
@kenkunz kenkunz changed the title Trading pair details page refresh Trading pair details page refresh (part 1) Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: P1 An important issue that must be fixed before the next release, but does nto require immediate focus. size: M An ordinary task that can be completed in a few days or in a week
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant