Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC][Study] Vite for bundling and storybook #368

Closed
seedy opened this issue Apr 25, 2022 · 0 comments · Fixed by #423
Closed

[RFC][Study] Vite for bundling and storybook #368

seedy opened this issue Apr 25, 2022 · 0 comments · Fixed by #423
Assignees
@matthieuh @seedy @paulocfjunior @gndz07
Labels
area/infrastructure Pull requests that update infra/dependencies dependencies Pull requests that update a dependency file kind/proposal question Further information is requested

Comments

@seedy
Copy link
Contributor

seedy commented Apr 25, 2022 •
edited
Loading

Goals

  • improve bundling
  • improve storybook build and hmr

Background

Currently, we use storybook's core builder, which is based on webpack.

Our new project architecture: esModule

Storybook build is pretty slow and there's no Hot Module Reloading available for now.

Proposal

Study Vite, which is an opinionated framework to bundle, build, run apps.

Storybook has a blog article on integrating with Vite:
@seedy seedy changed the title [Study] Vite bundling over rollup [RFC][Study] Vite bundling over rollup Apr 25, 2022
@seedy seedy added question Further information is requested kind/proposal labels Apr 25, 2022
@seedy seedy changed the title [RFC][Study] Vite bundling over rollup [RFC][Study] Vite for bundling and storybook Apr 29, 2022
@seedy seedy added area/infrastructure Pull requests that update infra/dependencies dependencies Pull requests that update a dependency file labels Apr 29, 2022
@gndz07 gndz07 mentioned this issue Mar 7, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthieuh matthieuh

@seedy seedy

@paulocfjunior paulocfjunior

@gndz07 gndz07

Labels
area/infrastructure Pull requests that update infra/dependencies dependencies Pull requests that update a dependency file kind/proposal question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump deps, use vite framework and bundling gndz07/faency
4 participants
@matthieuh @seedy @paulocfjunior @gndz07