Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps, use vite framework and bundling #423

Merged
merged 13 commits into from
Mar 8, 2024

Conversation

gndz07
Copy link
Member

@gndz07 gndz07 commented Mar 7, 2024

Description

  • Change node to v20
  • use yarn
  • bump storybook to v7
  • use vite as framework and bundler

No visual changes, no breaking changes for user.

Dependency changes

Dependency Version State
storybook 6.5.15 -> 7.6.17 Updated
@storybook/react-vite 7.6.17 Added
@storybook/react 6.5.15 -> 7.6.17 Updated
@storybook/react-webpack5 6.5.15 Removed
storybook-dark-mode 2.0.5 -> 3.0.3 Updated

All @storybook/* dependencies updated to v7.6.17.

Good PR checkboxes

  • Change has been tested
  • Added/Updated tests
  • Added/Updated stories
  • PR follows conventions
  • Labels are set
  • Project is linked

Good Review checkboxes

ℹ️ Copy the snippet and paste in the review field to fill it
- [ ] I've tested the changes
- [ ] I've agreed on the unit tests (soon to come)
- [ ] I've checked the stories
- [ ] I've read the code and understood it
- [ ] I don't have any more questions
- [ ] I've described any optional improvements
- [ ] I checked PR follows [conventions](https://github.com/traefik/faency#how-to-contribute)

@gndz07 gndz07 marked this pull request as ready for review March 8, 2024 10:06
@gndz07 gndz07 added status/2-needs-review area/infrastructure Pull requests that update infra/dependencies 00-type/task labels Mar 8, 2024
@gndz07 gndz07 requested a review from mdeliatf March 8, 2024 10:06
Copy link
Contributor

@mdeliatf mdeliatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@traefiker traefiker merged commit 446f3a6 into traefik:master Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
00-type/task area/infrastructure Pull requests that update infra/dependencies
Projects
None yet
3 participants