Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: button compound variants #445

Merged
merged 7 commits into from
Aug 5, 2024
Merged

fix: button compound variants #445

merged 7 commits into from
Aug 5, 2024

Conversation

gndz07
Copy link
Member

@gndz07 gndz07 commented Aug 5, 2024 •
edited
Loading

Description

⚠️ there seems to be a slight issue with the hot reload on storybook, sometimes it causes bugs after changing variants. Try to completely reload the page if a weird UI happened. We will track this problem with storybook in a separated issue.

Preview

image image image image

@gndz07 gndz07 requested a review from mdeliatf August 5, 2024 08:41
mdeliatf
mdeliatf approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@mdeliatf mdeliatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@traefiker traefiker merged commit ea60ab3 into traefik:master Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeliatf mdeliatf mdeliatf approved these changes

Assignees
No one assigned
Labels
kind/bug/fix a bug fix
Projects
None yet
Milestone
No milestone
3 participants
@gndz07 @mdeliatf @traefiker