Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accordion trigger disabled style and custom icon #450

Merged
merged 3 commits into from
Sep 16, 2024
Merged

fix: accordion trigger disabled style and custom icon #450

merged 3 commits into from
Sep 16, 2024

Conversation

gndz07
Copy link
Member

@gndz07 gndz07 commented Sep 16, 2024

Description

Needed to complete https://github.com/traefik/hub-issues/issues/1308

  • Fix disabled accordion trigger styling
  • Add props to remove icon from trigger
  • Add possibility to use custom icon for accordion trigger

Preview

image

@gndz07 gndz07 requested a review from mdeliatf September 16, 2024 15:26
mdeliatf
mdeliatf approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@mdeliatf mdeliatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@traefiker traefiker merged commit 6332ffa into traefik:master Sep 16, 2024
2 checks passed
@traefiker
Copy link
Contributor

🎉 This PR is included in version 10.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeliatf mdeliatf mdeliatf approved these changes

Assignees
No one assigned
Labels
kind/bug/fix a bug fix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gndz07 @traefiker @mdeliatf