feat: allow setting permanent on redirectTo #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
mloiseleur
approved these changes
Jun 12, 2024
|
Thanks @berlincount. This PR looks good 👍 |
madic-creates
pushed a commit
to madic-creates/k3s-git-ops
that referenced
this pull request
Oct 25, 2024
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [traefik](https://traefik.io/) ([source](https://github.com/traefik/traefik-helm-chart)) | HelmChart | major | `27.0.2` -> `29.0.1` | `30.0.1` (+1) | --- ### Release Notes <details> <summary>traefik/traefik-helm-chart (traefik)</summary> ### [`v29.0.1`](https://github.com/traefik/traefik-helm-chart/releases/tag/v29.0.1) [Compare Source](traefik/traefik-helm-chart@v29.0.0...v29.0.1) ##### [29.0.1](traefik/traefik-helm-chart@v29.0.0...v29.0.1) (2024-07-09) ##### Features - ✨ publish chart on OCI registry ([deaddf5](traefik/traefik-helm-chart@deaddf5)) ##### Bug Fixes - RBACs for hub and disabled namespaced RBACs ([0827106](traefik/traefik-helm-chart@0827106)) - semverCompare failing on some legitimate tags ([143b96f](traefik/traefik-helm-chart@143b96f)) ### [`v29.0.0`](https://github.com/traefik/traefik-helm-chart/releases/tag/v29.0.0) [Compare Source](traefik/traefik-helm-chart@v28.3.0...v29.0.0) ##### Upgrade Notes This is a major breaking upgrade. [Migration guide](https://doc.traefik.io/traefik/v3.1/migration/v3/#v30-to-v31) from v3.0 to v3.1rc has been applied on this chart. This release supports both Traefik Proxy v3.0.x and v3.1rc. It comes with those⚠️ breaking changes⚠️ : - Far better support on Gateway API v1.1: Gateway, GatewayClass, CRDs & RBAC ([#​1107](traefik/traefik-helm-chart#1107)) - Many changes on CRDs & RBAC ([#​1072](traefik/traefik-helm-chart#1072) & [#​1108](traefik/traefik-helm-chart#1108)) - Refactor on Prometheus Operator support. Values has changed ([#​1114](traefik/traefik-helm-chart#1114)) - Dashboard `IngressRoute` is now disabled by default ([#​1111](traefik/traefik-helm-chart#1111)) CRDs needs to be upgraded: `kubectl apply --server-side --force-conflicts -k https://github.com/traefik/traefik-helm-chart/traefik/crds/` ##### Features - ✨ migrate to endpointslices rbac ([0449b0b](traefik/traefik-helm-chart@0449b0b)) - ✨ update CRDs & RBAC for Traefik Proxy ([228c4e4](traefik/traefik-helm-chart@228c4e4)) - allow to set hostAliases for traefik pod ([42e5745](traefik/traefik-helm-chart@42e5745)) - **dashboard:** dashboard `IngressRoute` should be disabled by default ([d9b856a](traefik/traefik-helm-chart@d9b856a)) - **providers:** add nativeLBByDefault support ([e75a85c](traefik/traefik-helm-chart@e75a85c)) - **providers:** improve kubernetesGateway and Gateway API support ([2eb640a](traefik/traefik-helm-chart@2eb640a)) - **workflow:** add oci push ([aa3022a](traefik/traefik-helm-chart@aa3022a)) ##### Bug Fixes - **dashboard:** Only set ingressClass annotation when kubernetesCRD provider is listening for it ([f142f6c](traefik/traefik-helm-chart@f142f6c)) - **rbac:** nodes API permissions for Traefik v3.1+ ([647439d](traefik/traefik-helm-chart@647439d)) - allow multiples values in the `secretResourceNames` slice ([24978e8](traefik/traefik-helm-chart@24978e8)) - 🐛 improve error message on additional service without ports ([d4cab24](traefik/traefik-helm-chart@d4cab24)) - prometheus operator settings ([7d3a90d](traefik/traefik-helm-chart@7d3a90d)) ##### Documentation - fix typos and broken link ([e43afd4](traefik/traefik-helm-chart@e43afd4)) #### New Contributors - [@​justinrush](https://github.com/justinrush) made their first contribution in traefik/traefik-helm-chart#1093 - [@​x0ddf](https://github.com/x0ddf) made their first contribution in traefik/traefik-helm-chart#1094 - [@​traefiker](https://github.com/traefiker) made their first contribution in traefik/traefik-helm-chart#1101 - [@​mmetc](https://github.com/mmetc) made their first contribution in traefik/traefik-helm-chart#1102 ### [`v28.3.0`](https://github.com/traefik/traefik-helm-chart/releases/tag/v28.3.0) [Compare Source](traefik/traefik-helm-chart@v28.2.0...v28.3.0) ##### Features - allow setting permanent on redirectTo ([1b454e9](traefik/traefik-helm-chart@1b454e9)) ##### Bug Fixes - **Security:** 🐛 🔒️ mount service account token on pod level (\[[`db4f43f`](https://github.com/traefik/traefik-helm-chart/commit/db4f43f)]\(https://github.com/traefik/traefik-helm-chart/commit/ - **Traefik Hub:** remove namespace in mutating webhook ([f8f2da2](traefik/traefik-helm-chart@f8f2da2)) - **Traefik Hub:** remove obsolete CRD ([4fcec62](traefik/traefik-helm-chart@4fcec62)) - 🐛 namespaced rbac when kubernetesIngress provider is disabled ([3bb41f7](traefik/traefik-helm-chart@3bb41f7)) [`db4f43f`](traefik/traefik-helm-chart@db4f43f))) - 🐛 add divisor: '1' to GOMAXPROCS and GOMEMLIMIT ([9ccbee2](traefik/traefik-helm-chart@9ccbee2)) #### New Contributors - [@​hawkesn](https://github.com/hawkesn) made their first contribution in traefik/traefik-helm-chart#1085 - [@​berlincount](https://github.com/berlincount) made their first contribution in traefik/traefik-helm-chart#1082 **Full Changelog**: traefik/traefik-helm-chart@v28.2.0...v28.3.0 ### [`v28.2.0`](https://github.com/traefik/traefik-helm-chart/releases/tag/v28.2.0) [Compare Source](traefik/traefik-helm-chart@v28.1.0...v28.2.0) :warning: This release align to Kubernetes default (*Always*) for `podSecurityContext.fsGroupChangePolicy`. It was *OnRootMismatch* in previous release of this chart. It can easily be set (back) to *OnRootMismatch* if needed, see [EXAMPLES](https://github.com/traefik/traefik-helm-chart/blob/master/EXAMPLES.md#use-traefik-native-lets-encrypt-integration-without-cert-manager). ##### Features - ✨ simplify values and provide more examples ([4eb71eb](traefik/traefik-helm-chart@4eb71eb)) - add deletecollection right on secrets ([fb69807](traefik/traefik-helm-chart@fb69807)) - update traefik docker tag to v3.0.1 by [@​renovate](https://github.com/renovate) in traefik/traefik-helm-chart#1075 ##### Bug Fixes - **IngressClass:** provides annotation on IngressRoutes when it's enabled ([f5de0c3](traefik/traefik-helm-chart@f5de0c3)) #### New Contributors - [@​jspdown](https://github.com/jspdown) made their first contribution in traefik/traefik-helm-chart#1077 **Full Changelog**: traefik/traefik-helm-chart@v28.1.0...v28.2.0 ### [`v28.1.0`](https://github.com/traefik/traefik-helm-chart/releases/tag/v28.1.0) [Compare Source](traefik/traefik-helm-chart@v28.0.0...v28.1.0) ##### Features - **Traefik Hub:** add initial support for API Gateway ([dc5c68d](traefik/traefik-helm-chart@dc5c68d)) - **Traefik Hub:** use Traefik Proxy otlp config ([a910db4](traefik/traefik-helm-chart@a910db4)) ##### Bug Fixes - **Traefik Hub:** refine support ([60d210d](traefik/traefik-helm-chart@60d210d)) - **Traefik Hub:** do not deploy mutating webhook when enabling only API Gateway ([cb2a98d](traefik/traefik-helm-chart@cb2a98d)) ##### Documentation - **example:** Update Digital Ocean PROXY Protocol ([9850319](traefik/traefik-helm-chart@9850319)) - 📚️ improve UPGRADING section ([54ec665](traefik/traefik-helm-chart@54ec665)) ### [`v28.0.0`](https://github.com/traefik/traefik-helm-chart/releases/tag/v28.0.0) [Compare Source](traefik/traefik-helm-chart@v27.0.2...v28.0.0) ##### ⚠ BREAKING CHANGES - 💥 initial support of Traefik Proxy v3 - See [Migration guide from v2 to v3](https://doc.traefik.io/traefik/v3.0/migration/v2-to-v3/) and upgrading section of this chart on CRDs. ##### Features - **podtemplate:** set GOMEMLIMIT, GOMAXPROCS when limits are defined ([e4f2aa8](traefik/traefik-helm-chart@e4f2aa8)) - 💥 initial support of Traefik Proxy v3 ([536059d](traefik/traefik-helm-chart@536059d)) - ✨ add support of `experimental-v3.0` unstable version ([579984c](traefik/traefik-helm-chart@579984c)) - ✨ fail gracefully when required port number is not set ([f8be5e1](traefik/traefik-helm-chart@f8be5e1)) - **ports:** add transport options ([47e0f28](traefik/traefik-helm-chart@47e0f28)) - ability to override liveness and readiness probe paths ([ea95df0](traefik/traefik-helm-chart@ea95df0)) ##### Bug Fixes - 🐛 logs filters on status codes ([c204014](traefik/traefik-helm-chart@c204014)) - 🐛 only expose http3 port on service when TCP variant is exposed ([2d6243d](traefik/traefik-helm-chart@2d6243d)) ##### Styles - 🎨 consistent capitalization on `--entryPoints` CLI flag ([b1f6f96](traefik/traefik-helm-chart@b1f6f96)) ##### Documentation - 📚️ improve EXAMPLES on acme resolver ([2252aba](traefik/traefik-helm-chart@2252aba)) #### New Contributors - [@​matkam](https://github.com/matkam) made their first contribution in traefik/traefik-helm-chart#1041 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://code.geekbundle.org/madic/git-ops-dev/pulls/168 Co-authored-by: renovate Bot <renovate@geekbundle.org> Co-committed-by: renovate Bot <renovate@geekbundle.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Traefik allows to make
redirectTos permanent, but this wasn't supported by the Helm template yet.This PR adds support for this functionality, and closes #1076.
Motivation
I was trying to configure this per
values, but was only able to do so via aadditionalArgument, which I consider less elegant and less in line with the way Helm charts are supposed to work. Given the invitation to submit a PR in #1076, I just took the time.More
make testand all the tests passed