-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Chart): 📦 add optional separated chart for CRDs #1223
base: master
Are you sure you want to change the base?
Conversation
bd35651
to
b674cf7
Compare
9087b4b
to
e1eb8a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The CI needs to be tested, with a tag on your fork.
- The documented CRDs upgrade process should still work. I see (at least) two options:
a. Keep and copy crd files
b. Update CRD upgrade instruction to use them in the new directory
e9619df
to
6a67459
Compare
Tested on my own account as seen with you 👍 |
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
b296543
to
1f5ddd5
Compare
Following this last review, the behavior observed when using the dedicated crd chart as a dependency is clearly not satisfactory:
The only viable option left is to provide an additional optional chart for CRD, without using dependency mechanism. |
a53e8f1
to
59d7ecc
Compare
59d7ecc
to
4da2fa0
Compare
README.md
Outdated
helm list -n traefik | ||
# NAME NAMESPACE REVISION UPDATED STATUS CHART APP VERSION | ||
# traefik traefik 1 2025-01-08 15:37:24.918465001 +0100 CET deployed traefik-33.2.1 v3.2.3 | ||
# traefik-crds traefik 1 2025-01-08 15:37:18.863333527 +0100 CET deployed traefik-crds-0.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# traefik-crds traefik 1 2025-01-08 15:37:18.863333527 +0100 CET deployed traefik-crds-0.0.1 | |
# traefik-crds traefik 1 2025-01-08 15:37:18.863333527 +0100 CET deployed traefik-crds-1.0.0 |
gatewayAPI: false # @schema type:[string, boolean]; default: false | ||
hub: false # @schema type:[string, boolean]; default: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gatewayAPI: false # @schema type:[string, boolean]; default: false | |
hub: false # @schema type:[string, boolean]; default: false | |
gatewayAPI: false | |
hub: false |
@@ -0,0 +1,4 @@ | |||
traefik: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdyt of providing comments explaining what it does ?
What does this PR do?
This PR introduces a separate chart used by the main one to install CRDs.
The dependency between the main chart and the CRDs one will be added once CRDs one will be released.
Motivation
#1141
#1209
More
make test
and all the tests passed