Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Chart): 📦 add optional separated chart for CRDs #1223

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

darkweaver87
Copy link
Contributor

@darkweaver87 darkweaver87 commented Oct 14, 2024

What does this PR do?

This PR introduces a separate chart used by the main one to install CRDs.
The dependency between the main chart and the CRDs one will be added once CRDs one will be released.

Motivation

#1141
#1209

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

@darkweaver87 darkweaver87 added kind/enhancement New feature or request kind/proposal a proposal that needs to be discussed. labels Oct 14, 2024
@darkweaver87 darkweaver87 force-pushed the feat/crds branch 2 times, most recently from bd35651 to b674cf7 Compare October 14, 2024 08:39
@darkweaver87 darkweaver87 changed the title feat: 📦 add separated chart for CRDs feat!: 📦 add separated chart for CRDs Oct 14, 2024
traefik/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The CI needs to be tested, with a tag on your fork.
  2. The documented CRDs upgrade process should still work. I see (at least) two options:
    a. Keep and copy crd files
    b. Update CRD upgrade instruction to use them in the new directory

@darkweaver87 darkweaver87 force-pushed the feat/crds branch 2 times, most recently from e9619df to 6a67459 Compare October 21, 2024 06:50
@darkweaver87
Copy link
Contributor Author

darkweaver87 commented Oct 21, 2024

Tested on my own account as seen with you 👍

@mloiseleur mloiseleur changed the title feat(Chart)!: 📦 add separated chart for CRDs feat(Chart): 📦 add optional separated chart for CRDs Jan 8, 2025
traefik/values.yaml Outdated Show resolved Hide resolved
traefik/values.yaml Outdated Show resolved Hide resolved
@mloiseleur
Copy link
Contributor

Following this last review, the behavior observed when using the dedicated crd chart as a dependency is clearly not satisfactory:

  • it's not possible to use CR like the Dashboard or a Gateway: the CRDs are not yet deployed.

The only viable option left is to provide an additional optional chart for CRD, without using dependency mechanism.
User will have to take care of correct versioning between this Traefik Chart and this CRD chart.
The documentation should be updated to explain how to deploy this Chart, with a clean cluster or with a Traefik Chart already installed.

@darkweaver87 darkweaver87 force-pushed the feat/crds branch 2 times, most recently from a53e8f1 to 59d7ecc Compare January 8, 2025 14:51
README.md Outdated
helm list -n traefik
# NAME NAMESPACE REVISION UPDATED STATUS CHART APP VERSION
# traefik traefik 1 2025-01-08 15:37:24.918465001 +0100 CET deployed traefik-33.2.1 v3.2.3
# traefik-crds traefik 1 2025-01-08 15:37:18.863333527 +0100 CET deployed traefik-crds-0.0.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# traefik-crds traefik 1 2025-01-08 15:37:18.863333527 +0100 CET deployed traefik-crds-0.0.1
# traefik-crds traefik 1 2025-01-08 15:37:18.863333527 +0100 CET deployed traefik-crds-1.0.0

Comment on lines +2 to +3
gatewayAPI: false # @schema type:[string, boolean]; default: false
hub: false # @schema type:[string, boolean]; default: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gatewayAPI: false # @schema type:[string, boolean]; default: false
hub: false # @schema type:[string, boolean]; default: false
gatewayAPI: false
hub: false

@@ -0,0 +1,4 @@
traefik: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt of providing comments explaining what it does ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot/no-merge kind/enhancement New feature or request kind/proposal a proposal that needs to be discussed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don’t bundle Gateway API CRDs CRD only Helm chart for Traefik
4 participants