Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix namespaceSelector on ServiceMonitor #737

Merged
merged 1 commit into from
Nov 23, 2022
Merged

🐛 Fix namespaceSelector on ServiceMonitor #737

merged 1 commit into from
Nov 23, 2022

Conversation

mloiseleur
Copy link
Contributor

What does this PR do?

Fix wrong indentation on namespaceSelector of (optional) ServiceMonitor integration.

Motivation

Fixes #736

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mloiseleur mloiseleur merged commit 76af68c into traefik:master Nov 23, 2022
@mloiseleur mloiseleur deleted the fix/sm branch November 23, 2022 08:07
terrych0u pushed a commit to terrych0u/traefik2-helm-chart that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom NamespaceSelector in ServiceMonitor not working
2 participants