Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add support for OpenTelemetry and Traefik v3 #760

Merged
merged 1 commit into from
Dec 8, 2022
Merged

✨ add support for OpenTelemetry and Traefik v3 #760

merged 1 commit into from
Dec 8, 2022

Conversation

charlie-haley
Copy link
Contributor

What does this PR do?

This PR adds:

  • a temporary, experimental.v3 flag to enable Traefik Proxy v3 (This will be deprecated on release and v3 will be the new default version).
  • Support for Open Telemetry configuration in the Values file.
  • Updating tests
  • Returning a post-install message with the image tag version, if used

mloiseleur
mloiseleur approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darkweaver87
darkweaver87 approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlie-haley charlie-haley force-pushed the feat/opentelemetry-support branch from 5a8eb50 to dd19613 Compare December 8, 2022 14:04
darkweaver87
darkweaver87 approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mloiseleur mloiseleur mentioned this pull request Dec 8, 2022
Closed
5 tasks
@traefiker traefiker merged commit b45c548 into traefik:master Dec 8, 2022
This was referenced Sep 27, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur approved these changes

@darkweaver87 darkweaver87 darkweaver87 approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charlie-haley @darkweaver87 @mloiseleur @traefiker