Fix existing tag detection in workflow #777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix failing workflows for commits on
master
with existing tags.Motivation
Currently the step
Check if tag exists
on therelease
job fails to detect existing tags, because it does not account for the prefixv
added (by default) by theTag release
action. This causes any commits not updating the chart version to result in a failure on therelease
job, as theTag release
job will fail with message "Validation Failed: {"resource":"Release","code":"already_exists","field":"tag_name"}".This PR explicitly adds the prefix to both stages, so that existing tag detection works properly.
See also
succesful example run on my fork
andcurrently failing run on master
.More
Yes, I updated the tests accordinglyYes, I ranmake test
and all the tests passed