Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing tag detection in workflow #777

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

jnoordsij
Copy link
Collaborator

@jnoordsij jnoordsij commented Jan 9, 2023

What does this PR do?

Fix failing workflows for commits on master with existing tags.

Motivation

Currently the step Check if tag exists on the release job fails to detect existing tags, because it does not account for the prefix v added (by default) by the Tag release action. This causes any commits not updating the chart version to result in a failure on the release job, as the Tag release job will fail with message "Validation Failed: {"resource":"Release","code":"already_exists","field":"tag_name"}".

This PR explicitly adds the prefix to both stages, so that existing tag detection works properly.

See also succesful example run on my fork and currently failing run on master.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@charlie-haley charlie-haley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Thanks @jnoordsij , it looks good !

@traefiker traefiker merged commit d1a2c28 into traefik:master Jan 9, 2023
@jnoordsij jnoordsij deleted the fix-release-workflow branch January 9, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants