Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to set dnsConfig on pod template #821

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

RouxAntoine
Copy link
Contributor

What does this PR do?

Add the possiblity to override pod dns configuration

Motivation

I would like to force my traefik instance to use a public dns to avoid outage when my own dns is down

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

@mloiseleur mloiseleur changed the title feature: allow dnsConfig parameter overriding in deployment thanks to pod template spec feat: allow to set dnsConfig on pod template Apr 11, 2023
@RouxAntoine RouxAntoine force-pushed the feature/dnsconfig-override branch from c4d70d6 to 4a71ed1 Compare April 11, 2023 17:56
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and the update.
I left a few comments about the tests.

traefik/tests/pod-config_test.yaml Show resolved Hide resolved
traefik/tests/pod-config_test.yaml Show resolved Hide resolved
traefik/tests/pod-config_test.yaml Show resolved Hide resolved
@RouxAntoine RouxAntoine force-pushed the feature/dnsconfig-override branch from 4a71ed1 to ab50a71 Compare April 12, 2023 10:33
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RouxAntoine
Copy link
Contributor Author

thanks everybody 🚀

@RouxAntoine RouxAntoine deleted the feature/dnsconfig-override branch April 13, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants