Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 traefik or metrics port can be disabled #891

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: 🐛 traefik or metrics port can be disabled #891

merged 2 commits into from
Jul 24, 2023

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Jul 21, 2023

What does this PR do?

Solve error encountered when trying to disable traefik or metrics port.
/!\ Note that when you disable traefik ports, liveness probe will be directly on web port.

Motivation

See #890.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may wanna test if ports are really disabled when it's disabled through values

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3633974 into traefik:master Jul 24, 2023
@mloiseleur mloiseleur deleted the fix/890 branch September 14, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants