Release namespace for Prometheus Operator resources

[bennesp]

What does this PR do?

Set namespace for ServiceMonitor and PrometheusRule resources to the release namespace if no namespace is set into the values file, like all others resources

Motivation

Closes #948 which seems to be stale

More

• Yes, I updated the tests accordingly
• Yes, I ran make test and all the tests passed

[mloiseleur]

Thanks for this PR !

In order keep good readability, we try avoid having

{{- if x }}
field: value
{{- else }}
field: othervalue
{{- end }}

Would you please use a template or a ternary instead ?

You should also start with the test, on both objects. The tests should fail without your changes on the template.

[bennesp]

Can you clarify this sentence please?

> You should also start with the test, on both objects. The tests should fail without your changes on the template.

I am asking because tests are already in place, and they fails without these changes already, so I am a bit confused

Apologies, I got now that you were referring to the other template that the original author modified, will write tests also for that template

[mloiseleur]

LGTM

[mloiseleur]

Apologies, I got now that you were referring to the other template that the original author modified, will write tests also for that template

No problem. Thanks for rebasing and updating the PR. It looks better now.

[darkweaver87]

LGTM