Move some stuff in the right packages #1006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
force-pushed
the
mini-packaging-refactoring
branch
4 times, most recently
from
bb5a014 to
834ba29
Compare
emilevauge
reviewed
Jan 3, 2017
| @@ -21,10 +21,10 @@ WORKDIR /go/src/github.com/containous/traefik | |||
|
|
|||
| COPY glide.yaml glide.yaml | |||
| COPY glide.lock glide.lock | |||
| RUN glide install -v | |||
| RUN glide install --strip-vendor | |||
There was a problem hiding this comment.
@vdemeester why strip-vendor ?
There was a problem hiding this comment.
-v is the shortcut for --strip-vendor, it makes sense to use the full flag for documentation...
dtomcej
reviewed
Jan 4, 2017
| # Using gox to build multiple platform | ||
| $ gox "linux darwin" "386 amd64 arm" \ | ||
| -output="dist/traefik_{{.OS}}-{{.Arch}}" | ||
| $ go build -o dist/traefik ./cmd/ |
There was a problem hiding this comment.
Do you really want to specify the output path? the binary is in the gitignore for the root directory. Instead, could you add a shim build in root that just "forwards" to ./cmd? Sorry for the terrible terminology, but go build is such a simple dev command, that we really should fight to keep ;)
vdemeester
force-pushed
the
mini-packaging-refactoring
branch
from
834ba29 to
d2d43c5
Compare
vdemeester
force-pushed
the
mini-packaging-refactoring
branch
2 times, most recently
from
ea46d3c to
30b85fb
Compare
emilevauge
force-pushed
the
mini-packaging-refactoring
branch
from
30b85fb to
41e9483
Compare
- This will help split stuff in smaller, better tested packages - This moves some stuff like the traefik command to package `cmd` Signed-off-by: Vincent Demeester <vincent@sbr.pm>
SantoDE
force-pushed
the
mini-packaging-refactoring
branch
from
41e9483 to
47894e5
Compare
|
@vdemeester What do you want to do with this PR? Closing? |
|
Should close this.. it's too old, I'll redo if I get some time 😝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmdNote that this is a start (and stays small) but the
serverpackage should be split up then, etc./cc @containous/traefik
🐸
Signed-off-by: Vincent Demeester vincent@sbr.pm