Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ResourceAttributes instead of GlobalAttributes #11515

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Use ResourceAttributes instead of GlobalAttributes #11515

merged 2 commits into from
Feb 6, 2025
+19 −6

Conversation

bruno-de-queiroz
Copy link
Contributor

What does this PR do?

Fixes the custom attributes setup. The GlobalAttributes is marked as deprecated in favor of ResourceAttributes, but the backend.setup was still using the GlobalAttributes

Motivation

Users can't assign custom attributes to the span via ResourceAttributes, and the Helm chart no longer allows globalAttributes.

More

  • Added/updated tests
  • [-] Added/updated documentation

Additional Notes

The documentation is already correct, I think it was just a piece of code that was forgotten when the ResourceAttributes were introduced.

Sorry, something went wrong.

@traefiker traefiker added this to the 3.3 milestone Feb 5, 2025
@bruno-de-queiroz bruno-de-queiroz mentioned this pull request Feb 5, 2025
Closed
1 task
@bruno-de-queiroz
Copy link
Contributor Author

Also, please review this one: traefik/paerser#63, because currently, it's not possible to simply add --tracing.resourcesAttributes.service.environment=test as a flag

@kevinpollet kevinpollet changed the title fix(tracing): using ResourceAttributes instead of GlobalAttributes Use ResourceAttributes instead of GlobalAttributes Feb 6, 2025
@kevinpollet
review: naming
Loading
Loading status checks…
9916d4f
kevinpollet
kevinpollet approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

rtribotte
rtribotte approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@traefiker
Copy link
Contributor

🚫 checks status: PR status: failure

@traefiker traefiker merged commit b74767b into traefik:v3.3 Feb 6, 2025
40 checks passed
@kevinpollet kevinpollet mentioned this pull request Feb 13, 2025
Merged
2 tasks
@symsfischer symsfischer mentioned this pull request Feb 27, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinpollet kevinpollet

@rtribotte rtribotte

Assignees
No one assigned
Labels
area/middleware/tracing kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bruno-de-queiroz @traefiker @kevinpollet @rtribotte