Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command bug content. #2002

Merged
merged 2 commits into from
Aug 25, 2017
Merged

Fix command bug content. #2002

merged 2 commits into from
Aug 25, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Aug 23, 2017

Description

  • Replace toml by json
  • fix anonymize.

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Aug 23, 2017
@ldez ldez added this to the 1.4 milestone Aug 23, 2017
emilevauge
emilevauge approved these changes Aug 24, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 Thanks @ldez !
LGTM

nmengin
nmengin approved these changes Aug 24, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

SantoDE
SantoDE reviewed Aug 25, 2017
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@emilevauge
Copy link
Member

emilevauge commented Aug 25, 2017 •
edited
Loading

@SantoDE sorry to ask but we need an approve and not a comment review here, otherwise, our friend @traefiker won't accept to merge this PR :(

@traefiker traefiker merged commit 8235cd3 into traefik:master Aug 25, 2017
@ldez ldez deleted the refactor/bug-cmd branch August 25, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@emilevauge emilevauge emilevauge approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/middleware kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @emilevauge @SantoDE @nmengin @traefiker