Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix seconds to really be seconds #2259

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

SantoDE
Copy link
Collaborator

@SantoDE SantoDE commented Oct 12, 2017

Description

This one fixes #2255. The Metadata Provider assumed for the Intervall Poll, that the given value is in seconds but instead it was in ms. So a multiplication with seconds was needed.

You can test it upfront with my experimental image:

santode/traefik:heavy_load

image

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@m3co-code m3co-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! LGTM :)

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ^^
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants