-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add retries request #232
Closed
Closed
add retries request #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
add-retries-request
branch
from
March 2, 2016 17:56
0925a97
to
4e8c88a
Compare
emilevauge
force-pushed
the
add-retries-request
branch
from
March 3, 2016 08:49
4e8c88a
to
3aeaf53
Compare
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
add-retries-request
branch
from
March 3, 2016 08:57
3aeaf53
to
ac6c4a8
Compare
Fix typo Unkown -> unknown in error
@emilevauge this is general to all providers, you cannot set different values by providers. Is this intended ? 👼 |
If you think I should add the possibility to override by provider, I'm OK to add it ;) |
Signed-off-by: Emile Vauge <emile@vauge.com>
Refactor hot reload
Signed-off-by: Emile Vauge <emile@vauge.com>
…nto add-retries-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds retry request in case of network error.
You can enable retry in your global config file adding
[retry]
.The default config set a maximum storage in memory by request of 2 Mo and a maximum attempts of (number servers in backend) -1.
Your can override this:
Fixes #210