Check all the C/N and SANs of provided certificates before generating ACME certificates #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
status/2-needs-review
kind/bug/fix
|
This looks awesome. Would also close #473 correct? |
…e ACME certificates only for domains which need it
traefiker
force-pushed
the
hotfix/acme-check-san-from-dyn-cert
branch
from
4f959f5
to
4c79a9a
Compare
ldez
changed the title
ldez
changed the title
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes ACME certificates generation.
So far, only C/N of provided certificates was checked before to generate ACME certificate.
This PR adds a check on the SANs and generates ACME certificates only for domains which need it.
Motivation
Only generate ACME certificates for domains which need it.
Fixes #473, #2920
More