Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use official Pebble Image. #3708

Merged
merged 2 commits into from
Aug 1, 2018
Merged

Use official Pebble Image. #3708

merged 2 commits into from
Aug 1, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Aug 1, 2018

What does this PR do?

Remove my fork and use official Let's Encrypt pebble image.

Motivation

No fork.

@ldez ldez added this to the 1.7 milestone Aug 1, 2018
mmatur
mmatur approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej suggested changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the file name be peddle.yml? or pebble.yml?

emilevauge
emilevauge approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit d62f7e2 into traefik:v1.7 Aug 1, 2018
@ldez ldez deleted the refactor/pebble branch August 1, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@emilevauge emilevauge emilevauge approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/acme kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @mmatur @emilevauge @dtomcej @traefiker