Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error pages #3894

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Fix error pages #3894

merged 1 commit into from
Sep 17, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Sep 17, 2018

What does this PR do?

Fix a bug on error pages.

Motivation

Fixes #3643

@traefiker traefiker added this to the 1.7 milestone Sep 17, 2018
ldez
ldez approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 0ae8cd9 into traefik:v1.7 Sep 17, 2018
@traefiker traefiker mentioned this pull request Sep 17, 2018
Closed
@kachkaev
Copy link
Contributor

I'll be happy to test this PR if there is a docker image that includes it 😉

@kachkaev
Copy link
Contributor

kachkaev commented Sep 19, 2018 •
edited
Loading

After upgrading to 1.7.0-rc.5 custom error pages finally work in my docker environment! Many thanks for looking at this @juliens!

The only thing remains missing for some of my error workflows is this #3420. Once the original {path} or {url} are passed down to the error handler, it'll be hard to find a use case when traefik’s custom error pages cannot be leveraged!

@RRAlex
Copy link
Contributor

RRAlex commented Sep 19, 2018

Does this fix a default error-page on a remote server on k8s too?
Or something else? :)

@ldez
Copy link
Contributor

ldez commented Sep 19, 2018

This PR fix error pages feature for all providers (Docker, k8s, marathon, ...)

@ldez ldez mentioned this pull request Oct 8, 2018
Closed
@juliens juliens deleted the fix-error-pages branch September 6, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@juliens @kachkaev @RRAlex @ldez @mmatur @nmengin @traefiker