interp: fix type check in constant unary operations #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In unary constant operations, the test for unsigned was defeated by testing for int first, which is true also for unsigned. Make sure that testing for unsigned precedes testing for int. Fixes #907.
mpl
approved these changes
Oct 16, 2020
In unary constant operations, the test for unsigned was defeated by testing for int first, which is true also for unsigned. Make sure that testing for unsigned precedes testing for int. Fixes #907.
traefiker
force-pushed
the
yaegi-fix-907
branch
from
0f51a3f to
4b5a6cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In unary constant operations, the test for unsigned was defeated by
testing for int first, which is true also for unsigned. Make sure that
testing for unsigned precedes testing for int.
Fixes #907.