Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n new LWC (AR+EG) #958

Closed
wants to merge 6 commits into from
Closed

i18n new LWC (AR+EG) #958

wants to merge 6 commits into from

Conversation

egraells
Copy link
Contributor

What does this PR do?

Add localization recipe

What issues does this PR fix or reference?

#

The PR fulfills these requirements:

[ ] Tests for the proposed changes have been added/updated.
[ ] Code linting and formatting was performed.

Functionality Before

<insert gif and/or summary>

Functionality After

<insert gif and/or summary>

@egraells egraells requested a review from a team as a code owner June 27, 2024 17:45
Copy link
Contributor

@satyasekharcvb satyasekharcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space after colon for the better readability and grammatically correct (maybe we can use nbsp). Rest, it looks good.

force-app/main/default/lwc/miscI18n/miscI18n.html Outdated Show resolved Hide resolved
force-app/main/default/lwc/miscI18n/miscI18n.html Outdated Show resolved Hide resolved
force-app/main/default/lwc/miscI18n/miscI18n.html Outdated Show resolved Hide resolved
force-app/main/default/lwc/miscI18n/miscI18n.html Outdated Show resolved Hide resolved
force-app/main/default/lwc/miscI18n/miscI18n.html Outdated Show resolved Hide resolved
Copy link
Contributor

@satyasekharcvb satyasekharcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use &nbsp; instead of space as HTML collapses whitespaces by default. Same for other spaces as well.

@egraells
Copy link
Contributor Author

egraells commented Aug 23, 2024

Hi Satya, changes done, after replacing spaces after colon with  

@albarivas albarivas closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants