Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deque instead of list for FIFO queue in Linux Socket buffer #1453

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented May 30, 2019

More efficient to use deque for FIFO buffer of Socket data. O(1) for popleft() instead of O(n) for insert(0, c) https://docs.python.org/3/library/collections.html#collections.deque


This change is Reviewable

Copy link
Contributor

@ehennenfent ehennenfent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ehennenfent ehennenfent merged commit ebdf2eb into master Jun 4, 2019
@ehennenfent ehennenfent deleted the use-deque branch June 4, 2019 19:10
ekilmer added a commit that referenced this pull request Jul 11, 2019
* master:
  Fix FileNotFoundError when loading existing state (#1480)
  Add undoc-members to api docs (#1478)
  Improve deprecation warnings (#1476)
  Fix sycall getdents (#1472)
  Dev apidocs refactor (#1469)
  Enforce black formatting (#1466)
  Moving issymbolic to smtlib (#1456)
  Revert Unicorn Dependency Update (#1459)
  Manticore 0.3.0 (#1448)
  Install native deps on rtd (#1457)
  Fix check for symbolic syscall argument (#1452)
  Use deque instead of list for FIFO queue in Linux Socket buffer (#1453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants