Use Coveralls for coverage #1783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehennenfent
reviewed
Jul 31, 2020
| pip install -e ".[dev-noks]" | ||
| - name: Run Tests | ||
| env: | ||
| TEST_TYPE: ${{ matrix.type }} | ||
| run: | | ||
| cp scripts/run_tests.sh . | ||
| ./run_tests.sh | ||
| - name: Coverage Upload | ||
| uses: codecov/codecov-action@v1 | ||
| - name: Coveralls Parallel |
There was a problem hiding this comment.
Is it necessary to manually install and run the CLI tool? Or can we use the GH action as shown in the example here: https://github.com/marketplace/actions/coveralls-github-action#complete-parallel-job-example
There was a problem hiding this comment.
Good question. I couldn't get it to work since it expects a .lcov file.
Here's an open issue if you can find a better workaround coverallsapp/github-action#30
ehennenfent
reviewed
Jul 31, 2020
|
I set the decrease threshold to 0.2%, but I left the total threshold blank |
Merged
|
Closing in favor of #1784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov has been extremely frustrating lately with failing to upload the results of our tests.
Since our tests take so long already, we don't want to have to re-run them multiple times to get differential coverage data
We need to allow https://coveralls.io/ to access this repo
We will need to add a Github secret token
COVERALLS_REPO_TOKENrelated to this repo to enable itThe settings for failing a PR for bad coverage is only managed in the web interface (pic below)
