If load config size is larger than reported, overwrite #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yardenshafir
force-pushed
the
yarden/use-correct-load-config-size
branch
from
bc1649f to
fa57793
Compare
woodruffw
reviewed
Jan 6, 2023
checksec.cpp
Outdated
| std::cerr << "Warn: load config larger than reported by data directory entry," | ||
| << " overwriting" | ||
| << "\n"; | ||
| memcpy(&loadConfig, loadConfigData.data(), loadConfig.Size); |
There was a problem hiding this comment.
We probably need a bounds check on loadConfigData.data() + loadConfig.Size, right?
LGTM otherwise!
There was a problem hiding this comment.
Don't think so, since the total data size is loadConfig.Size, we just overwrite the data we already copies earlier, not add to it.
There was a problem hiding this comment.
I meant for the PE container itself -- I could be wrong, but I think someone could modify a PE to set the load config's size to a size larger than the PE itself, meaning that loadConfigData.data() + loadConfig.Size would point past the end of the PE in memory.
There was a problem hiding this comment.
Ah, I see what you mean. Yeah, I'll add that check!
yardenshafir
force-pushed
the
yarden/use-correct-load-config-size
branch
3 times, most recently
from
85c33c0 to
1a5a52b
Compare
yardenshafir
force-pushed
the
yarden/use-correct-load-config-size
branch
from
1a5a52b to
c986ff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.