-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add info on SEO slug impact when making changes #1134
base: master
Are you sure you want to change the base?
Conversation
➖ Stations removed— 67982 – Bilice Stations changed
Truncated |
Could you clean-up the history and rebase (I hope this will restore the tests sanity)? I think we can merge |
You should probably not remove stations. It's probably an erroneous commit as it's not the subject. I think it has bitrotted, could you rebase and clean your history? |
@@ -5,3 +5,5 @@ When contributing, please indicate your data sources. | |||
Make sure the tests pass and submit a Pull Request. | |||
|
|||
It is possible to visualize and edit the data with https://trainline-eu.github.io/stations-studio. In order to make pull requests, you must be member of Trainline EU’s organisation. However it is possible to download the modified file without creating a pull request. | |||
|
|||
Please note: Changes to station names here not only impact what is shown in the search widget and booking flow, but also the SEO landing page URLs. For more info please see [this wiki](https://wiki.thetrainline.com/display/VUL/SEO+Station+Slugs+solution) on how the "SEO slugs" logic is implemented and the impact of updating a station name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should incorporate the change, however it would be best to phrase it in an agnostic way without mentionning internal sources.
No description provided.