-
Notifications
You must be signed in to change notification settings - Fork 2
Td 2435 generic assessment UI #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, just a few things, but I wasn't able to run it locally yet (I don't think the related updates are out in staging yet)
@@ -427,11 +451,36 @@ function setupCognitive() { | |||
}); | |||
} | |||
|
|||
function setupGeneric() { | |||
Traitify.http.authKey = "admin-secret"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does generic require a secret key to list them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, secret key is applied to listing query and mutation graphql request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd need to change that to public key since this is on the front-end, we can't use a secret key in the candidate's browser
@@ -240,6 +241,25 @@ function createElement(options = {}) { | |||
return element; | |||
} | |||
|
|||
function createGenericAssessment() { | |||
Traitify.http.authKey = "admin-secret"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also auth key
81d4fbf
to
a17c8c4
Compare
Code changes