Skip to content

Td 2435 generic assessment UI #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

prd-duy-huynh
Copy link

Code changes

@tomprats tomprats marked this pull request as ready for review June 24, 2025 14:55
@tomprats tomprats self-assigned this Jun 24, 2025
@tomprats tomprats self-requested a review June 24, 2025 14:55
@tomprats tomprats removed their assignment Jun 24, 2025
Copy link
Member

@tomprats tomprats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, just a few things, but I wasn't able to run it locally yet (I don't think the related updates are out in staging yet)

@@ -427,11 +451,36 @@ function setupCognitive() {
});
}

function setupGeneric() {
Traitify.http.authKey = "admin-secret";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does generic require a secret key to list them?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, secret key is applied to listing query and mutation graphql request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd need to change that to public key since this is on the front-end, we can't use a secret key in the candidate's browser

@@ -240,6 +241,25 @@ function createElement(options = {}) {
return element;
}

function createGenericAssessment() {
Traitify.http.authKey = "admin-secret";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also auth key

@prd-duy-huynh prd-duy-huynh requested a review from tomprats June 26, 2025 11:41
@prd-duy-huynh prd-duy-huynh force-pushed the TD-2435-generic-assessment-ui branch from 81d4fbf to a17c8c4 Compare June 27, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants