Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes and enhancements #80

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaelgomesxyz
Copy link
Member

This will be another big PR (hopefully the last one before the release). I hope to go over everything left on my to-do list.

@rafaelgomesxyz
Copy link
Member Author

rafaelgomesxyz commented Jun 30, 2021

@MrMamen Google offers a free tier with their cloud products, so I think it's better to store the database there instead of the Google Sheet. I separated a subdomain in my domain and was making some tests, and it seems to work quite well. Example: https://uts.rafaelgomes.xyz/api/correction-suggestions?ids=netflix_80103820,netflix_80103821 If it takes a while to load, it's because the instance was suspended (Google suspends instances that are idle for too long to save resources).

The free tier offers 28 instance hours per day (since we'll only use one instance, we'll only need 24 hours at most), and 50.000 database writes / 20.000 database reads per day (which I think should be more than enough).

If that's ok with you, I'll add uts.rafaelgomes.xyz as a required permission and make the appropriate changes.

@MrMamen
Copy link
Member

MrMamen commented Jun 30, 2021

Sure go ahead. It might be slightly harder to check the list, but it will probably be a smoother experience for the users.

@rafaelgomesxyz
Copy link
Member Author

For us, not really. I added you to the project, so if you go to https://console.cloud.google.com/firestore/data/?project=trakt-tools-uts you should be able to see the database.

@rafaelgomesxyz
Copy link
Member Author

Will start pushing commits tomorrow, since there are a lot of changes, in case you want to start reviewing them.

I think we can finally release it this month. This PR will fix #44, #46 and #72, and the only other issue that would be nice to fix before release is #47, but I think I can do that one quickly after I'm done with this PR. Will see how much I can do this weekend.

@rafaelgomesxyz
Copy link
Member Author

rafaelgomesxyz commented Jul 15, 2021

Had to deal with something last week, so didn't have time to work on it, but now I do.

I decided to make separate PRs in the end, to separate things better. First one is up: #81

@rafaelgomesxyz
Copy link
Member Author

rafaelgomesxyz commented Jul 19, 2021

@MrMamen I'm currently working on a PR to replace history pages with infinite scrolling. Just wondering if you're ok with that or if you think we should keep the pages.

I think the infinite scrolling is better because we don't have to worry about each page, and it also makes it easier to load more items if some items have been filtered. Right now, even if itemsToLoad is set to 10 and, let's say, 5 items were filtered because they're already synced, the page will display only 5 items. With infinite scrolling, we can load items on demand, so it doesn't matter how many items were filtered, it will always load more.

In that PR, I'm also removing the itemsToLoad option and making it always load 10, because since it's infinite scrolling, it doesn't make sense to allow the user to specify how much to load each time, and I think 10 is a good number. Let me know if you think we should keep this option as well.

@MrMamen
Copy link
Member

MrMamen commented Jul 22, 2021

@rafaelgomesxyz I think infinite scrolling is great.

@rafaelgomesxyz
Copy link
Member Author

rafaelgomesxyz commented Sep 5, 2021

I think we can finally release it this month.

And two months passed... lol

I'll try to finish the last PRs this next week. Only things I have left to do:

  • final dependency update, to get rid of some deprecated or outdated packages (Material-UI v4 to v5, moment to date-fns, etc.)
  • better typings (generic request response, split Item into Episode and Movie, remove all never types, etc.)
  • better errors (make sure that every error is properly dealt with)
  • fix any known remaining bugs (this PR)
  • prepare for traktflix migration
  • release

@MrMamen
Copy link
Member

MrMamen commented Oct 12, 2021

Any progress on this one?

@rafaelgomesxyz
Copy link
Member Author

Still working on it, but been a bit busy recently. Almost done with the better typings PR.

@rafaelgomesxyz rafaelgomesxyz force-pushed the master branch 6 times, most recently from c20b6e6 to 9f7ea72 Compare March 4, 2022 17:22
@rafaelgomesxyz rafaelgomesxyz force-pushed the master branch 3 times, most recently from b028f6a to a61949f Compare March 15, 2022 18:18
@rafaelgomesxyz rafaelgomesxyz force-pushed the master branch 6 times, most recently from e61dc9f to 6203ca0 Compare March 7, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants