-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various bug fixes and enhancements #80
base: master
Are you sure you want to change the base?
Conversation
@MrMamen Google offers a free tier with their cloud products, so I think it's better to store the database there instead of the Google Sheet. I separated a subdomain in my domain and was making some tests, and it seems to work quite well. Example: https://uts.rafaelgomes.xyz/api/correction-suggestions?ids=netflix_80103820,netflix_80103821 If it takes a while to load, it's because the instance was suspended (Google suspends instances that are idle for too long to save resources). The free tier offers 28 instance hours per day (since we'll only use one instance, we'll only need 24 hours at most), and 50.000 database writes / 20.000 database reads per day (which I think should be more than enough). If that's ok with you, I'll add |
Sure go ahead. It might be slightly harder to check the list, but it will probably be a smoother experience for the users. |
For us, not really. I added you to the project, so if you go to https://console.cloud.google.com/firestore/data/?project=trakt-tools-uts you should be able to see the database. |
Will start pushing commits tomorrow, since there are a lot of changes, in case you want to start reviewing them. I think we can finally release it this month. This PR will fix #44, #46 and #72, and the only other issue that would be nice to fix before release is #47, but I think I can do that one quickly after I'm done with this PR. Will see how much I can do this weekend. |
Had to deal with something last week, so didn't have time to work on it, but now I do. I decided to make separate PRs in the end, to separate things better. First one is up: #81 |
@MrMamen I'm currently working on a PR to replace history pages with infinite scrolling. Just wondering if you're ok with that or if you think we should keep the pages. I think the infinite scrolling is better because we don't have to worry about each page, and it also makes it easier to load more items if some items have been filtered. Right now, even if In that PR, I'm also removing the |
@rafaelgomesxyz I think infinite scrolling is great. |
And two months passed... lol I'll try to finish the last PRs this next week. Only things I have left to do:
|
Any progress on this one? |
Still working on it, but been a bit busy recently. Almost done with the better typings PR. |
c20b6e6
to
9f7ea72
Compare
b028f6a
to
a61949f
Compare
ec6ebb8
to
1c7387a
Compare
e61dc9f
to
6203ca0
Compare
This will be another big PR (hopefully the last one before the release). I hope to go over everything left on my to-do list.