fix: Some rules was unused and don't help with development (#172)

tramvaijs · Feb 5, 2022 · dca2c89 · dca2c89
1 parent 6127f5c
commit dca2c89
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/packages/eslint-config-react/index.js b/packages/eslint-config-react/index.js
@@ -44,7 +44,7 @@ module.exports = {
     'react/jsx-handler-names': 'warn',
     'react/prop-types': 'warn',
     'react/jsx-filename-extension': 'off',
-    'react/destructuring-assignment': 'warn',
+    'react/destructuring-assignment': 'off',
     'react/jsx-key': 'error',
     'react/no-direct-mutation-state': 'error',
     'react/default-props-match-prop-types': 'warn',

diff --git a/packages/eslint-config/internal/base.js b/packages/eslint-config/internal/base.js
@@ -50,7 +50,8 @@ module.exports = {
     ],
     'guard-for-in': 'off',
     'default-case': 'warn',
-    'no-plusplus': ['warn', { allowForLoopAfterthoughts: true }],
+    'no-plusplus': 'off',
+    'func-names': 'off',
     'consistent-return': 'warn',
     'vars-on-top': 'warn',
     'no-var': 'warn',
@@ -69,8 +70,8 @@ module.exports = {
         allowArrowFunctions: true,
       },
     ],
-    'max-depth': ['warn', 4],
-    'max-params': ['warn', 4],
+    'max-depth': 'off',
+    'max-params': 'off',
     'max-classes-per-file': ['error', 4],
     complexity: ['error', 25],
     'max-statements': ['error', 25],

diff --git a/packages/eslint-config/internal/test-files.js b/packages/eslint-config/internal/test-files.js
@@ -11,6 +11,7 @@ module.exports = {
         'prefer-promise-reject-errors': 'warn',
         'import/no-unresolved': 'off',
         'import/extensions': 'off',
+        '@typescript-eslint/no-shadow': 'off',
       },
     },
   ],

diff --git a/packages/eslint-config/jest.js b/packages/eslint-config/jest.js
@@ -14,5 +14,6 @@ module.exports = {
         ],
       },
     ],
+    'jest/no-disabled-tests': 'off',
   },
 };