Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 20229 #13062

Merged
merged 13 commits into from
Jun 13, 2024
Merged

B 20229 #13062

merged 13 commits into from
Jun 13, 2024

Conversation

deandreJones
Copy link
Contributor

@deandreJones deandreJones commented Jun 13, 2024

B-20229

INTEGRATION PR

Summary

Update FRA weekly effective period

Background

the app pulls the diesel prices every day looking for newly published prices
EIA publishes new prices generally every Monday, before this change they would just be effective until the next publication.
This change makes it so that when new diesel prices are published they are only valid from tueday( or the day after they are published0 through the following Monday

to test

  1. run make tasks_save_ghc_fuel_price_data to get the latest pricing data for your test
  2. create a new move
  3. approve move
  4. access prime and create a payment request for fuel surcharge
  5. login as TIO - review the payment request
  6. validate that it selected the correct price based on the actual pickup date being between the effective and End dates in the DB GHC_DIESEL_FUEL_PRICES
  • may want to manually enter a few extra rows verify it works and making the actual pickup date land on the effecting and end dates
Screenshot 2024-06-07 at 2 26 11 PM Screenshot 2024-06-07 at 2 57 05 PM image

@deandreJones deandreJones marked this pull request as ready for review June 13, 2024 16:57
@deandreJones deandreJones requested a review from a team as a code owner June 13, 2024 16:57
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits match up. lgtm!

Copy link
Contributor

@traskowskycaci traskowskycaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches up!

@deandreJones deandreJones merged commit a59e442 into main Jun 13, 2024
40 checks passed
@deandreJones deandreJones deleted the B-20229 branch June 13, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants