Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B19795-INT-REBASE-doc viewer doc title change #13776

Merged

Conversation

JamesHawks224
Copy link
Contributor

Agility ticket

B19795

Summary

For documents uploaded in the app, the documents were to have the document name in the format of - where timestamp is yyyymmddhh24minssecs e.g. sample.pdf-20240812134209. In addition, when the menu item is clicked in the document viewer, document name was to wrap (instead of being truncated).

How to test

testing prep:

  • suggest create a file w/a very long name e.g. "sample orders_company alpha_battalion twleve.pdf". This is sufficiently long enough to test document name wrapping in the document viewer

========

  • HHG move
    • customer
      • create a HHG move
      • submit move
      • go to: upload additional docs
        • upload file with long filename
        • confirm it uploaded in the format: filename-timestamp
      • go to: orders > upload documents
        • repeat same steps as "upload additional docs"
      • go to: review your request > orders > edit
        • repeat same steps as "upload additional docs"
    • service counselor
      • go to: view edit orders
        • in the doc viewer pane on the left, click the menu button
        • verify documents in the list wrap
        • click: manage orders
          • upload file
          • confirm it uploaded in the format: filename-timestamp
          • doc viewer: click the menu button and verify it appears
          • click "done"
        • click: manage amended orders
          • upload file
          • confirm it uploaded in the format: filename-timestamp
          • doc viewer: click the menu button and verify it appears
          • click "done"
        • fix order fields
      • go to: supporting docs
        • in the doc viewer pane on the left, click the menu button
        • verify documents in the list wrap
        • upload file
        • confirm it uploaded in the format: filename-timestamp
        • doc viewer: click the menu button and verify it appears
      • submit move
    • too: approve shipment
    • prime
      • create payment request
      • upload document with long name (to verify it wraps in the viewer)
        • note: unlike other upload locations in the app, when the file is uploaded, it will not have a timestamp in the name. the timestamp actually gets appended in the backend after "save" is clicked.
    • tio
      • click: review service items
      • doc viewer, click the menu button
        • confirm the file uploaded in the format: filename-timestamp
        • confirm it wraps in the menu list

========

  • PPM move
    • customer
      • create PPM move
      • submit move
    • service counselor: submit move
    • customer
      • click "upload ppm docs"
      • vehicle weight
        • empty, full docs: upload doc with long filename
      • add pro gear
        • customer: create pro gear item. upload doc with long filename
        • spouse: create pro gear item. upload doc with long filename
      • add expense: upload doc with long filename
      • submit documentation
    • service counselor
      • review docs
        • for each page
          • click the "menu" item
            • confirm each item in the list is in the format: filename-timestamp
            • confirm the item wraps if it is too long

ANDI Screenshots

No actionable UI elements were added

Testing Screenshots

none

@JamesHawks224 JamesHawks224 added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Sep 27, 2024
@JamesHawks224 JamesHawks224 requested a review from a team as a code owner September 27, 2024 19:00
@robot-mymove
Copy link

robot-mymove commented Sep 27, 2024

Warnings
⚠️ This PR does not include changes to unit tests, even though it affects app code.

Generated by 🚫 dangerJS against f8c4783

Copy link
Contributor

@WeatherfordAaron WeatherfordAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👽

@JamesHawks224 JamesHawks224 changed the title B19795 int3 doc viewer doc title change B19795-INT-REBASE-doc viewer doc title change Oct 9, 2024
Copy link
Contributor

@brooklyn-welsh brooklyn-welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JamesHawks224 JamesHawks224 merged commit 80aceb4 into integrationTesting Oct 10, 2024
30 checks passed
@JamesHawks224 JamesHawks224 deleted the B19795-INT3-Doc-viewer-doc-title-change branch October 10, 2024 14:25
@taeJungCaci taeJungCaci restored the B19795-INT3-Doc-viewer-doc-title-change branch October 23, 2024 14:43
@taeJungCaci taeJungCaci deleted the B19795-INT3-Doc-viewer-doc-title-change branch October 23, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

5 participants