B 22187 INT - Display tertiary delivery address under updated shipment in H&A Log

[ajlusk]

B-22187

Summary

Fixes a typo where "destination" was used instead of "delivery" (line 54). In the spirit of keeping things consistent I also updated the second address labels to not use a mix of "Second" and "Secondary". The use of "Secondary" appeared to come with the previously mentioned typo. "Second" and "Third" were the only ordinals used prior to that change.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Access the office app.
2. Login as a services counselor.
3. Select any unapproved move.
4. Add or modify the second and third pickup and destinations on a shipment.
5. Verify the move history correctly displays values for having both types of second and third addresses especially the third delivery address.

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[MInthavongsay]

Looks good

[antgmann]

Everything looks good. Waiting for happo to finish, and if all looks good, g2g!