-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAIN B-22206 #14574
Draft
danieljordan-caci
wants to merge
20
commits into
main
Choose a base branch
from
MAIN-B-22206
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
MAIN B-22206 #14574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of dest zip for display
… customer and AK shipment
danieljordan-caci
added
Mountain Movers
Movin' Mountains 1 Sprint at a time
MAIN
labels
Jan 13, 2025
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
This PR contains B-21708 so ensure it is merged prior to this
Agility ticket
Summary
There were some minor differences between the estimated and actual prices for basic HHG service items despite the weights and requested pickup dates being exactly the same. There were some rounding differences between the actual and estimated pricing and this BL is addressing changing the db procs & related functions to adjust to the flow of actual pricing.
NOTE you might want to update the last row of
ghc_diesel_fuel_prices
to be something above250,000
- I found that there was a one cent difference in the fuel surcharge service item when the number was negative. You could also runmake tasks_save_ghc_fuel_price_data
if ya want. I found the former to be faster.How to test
Screenshots