[HOLD] Pre-commit Fizz Validation #2286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjdufour-truss
force-pushed
the
precommit_fizz
branch
from
725f97e
to
4e17661
Compare
Codecov Report
@@ Coverage Diff @@
## master #2286 +/- ##
==========================================
- Coverage 59.29% 59.06% -0.24%
==========================================
Files 257 255 -2
Lines 14487 14396 -91
==========================================
- Hits 8590 8502 -88
+ Misses 4886 4879 -7
- Partials 1011 1015 +4 |
Makefile
Outdated
| @@ -179,6 +179,9 @@ bin/callgraph: .check_go_version.stamp .check_gopath.stamp | |||
| bin/chamber: .check_go_version.stamp .check_gopath.stamp | |||
| go build -ldflags "$(LDFLAGS)" -o bin/chamber github.com/segmentio/chamber | |||
|
|
|||
| bin/fizz-validate: .check_go_version.stamp .check_gopath.stamp | |||
| go build -ldflags "$(LDFLAGS)" -o bin/fizz-validate github.com/transcom/mymove/cmd/fizz-validate | |||
There was a problem hiding this comment.
Let's move this down to the section on MilMove Targets which is where the other binaries from this project are.
chrisgilmerproj
approved these changes
Jun 17, 2019
pjdufour-truss
force-pushed
the
precommit_fizz
branch
from
4e17661
to
380549f
Compare
|
Moved make target and pinged about merging PR to fizz. |
chrisgilmerproj
approved these changes
Jun 18, 2019
pjdufour-truss
changed the title
|
We're going to ice this PR for a month (until July 19) to check for a fix to fizz. |
|
Closing until the issue with Fizz is resolved. Infra has a ticket to reopen this if it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires: gobuffalo/fizz#54
This PR adds pre-commit validation for our fizz files. Requires an update to the fizz git repo.
Reviewer Notes
Is there anything you would like reviewers to give additional scrutiny?
Setup
Code Review Verification Steps
Querying the Database Safely
have been satisfied.
scripts/run-prod-migrationsReferences
None
Screenshots
None