Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

[NO-REF] Support tables config in get_binlog_streams and get_non_binlog_streams #154

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nicnguyen3103
Copy link

Problem

The discover_catalog function accepts the tables config but never use it. This mean users cannot choose which table to sync, meaning the tap-mysql will always sync all the tables in a database.

Proposed changes

  • Allow the discover_catalog function to receive tables config from the config section
  • User can now add the comma-separated table in the tables section of the config to select specific table to sync

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant