Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Adds support for MFA token caching #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnilrets
Copy link

Problem

Described in #305 - Allows a user who has MFA to only authenticate once per meltano run (instead of once for each snowflake query).

Proposed changes

Added the secure storage package and set the authenticator to username_password_mfa as described in the Snowflake docs.

While the authenticator is set to username_password_mfa, it works even if the user doesn't have MFA enabled. Since username/password is the only supported authentication method, this should have no impact on existing users who don't use MFA. We'd probably need more complex connection configuration logic if it was decided to use other auth methods (like OAuth or keypair).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Will work even if user does not use MFA.
@gnilrets
Copy link
Author

gnilrets commented Dec 2, 2022

@koszti - Any chance this could be reviewed and committed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant