This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Described in #305 - Allows a user who has MFA to only authenticate once per meltano run (instead of once for each snowflake query).
Proposed changes
Added the secure storage package and set the authenticator to
username_password_mfa
as described in the Snowflake docs.While the authenticator is set to
username_password_mfa
, it works even if the user doesn't have MFA enabled. Since username/password is the only supported authentication method, this should have no impact on existing users who don't use MFA. We'd probably need more complex connection configuration logic if it was decided to use other auth methods (like OAuth or keypair).Types of changes
Checklist
setup.py
is an individual PR and not mixed with feature or bugfix PRs[AP-NNNN]
(if applicable. AP-NNNN = JIRA ID)AP-NNN
(if applicable. AP-NNN = JIRA ID)