This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Add support for browser SSO authentication #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of the target only allows for Snowflake basic authentication, which is probably the most common way for Snowflake system users/service accounts to authenticate in a prod-like scenario.
Although, for development purposes, it is common for the authentication of personal Snowflake users to be done via the company's SSO (e.g. Google), using an external browser to follow the regular SSO auth flow.
It would be ideal for the target to support authentication using an external browser.
Proposed changes
In this PR I'm adding another authentication method, using SSO browser authentication, by:
use_browser_authentication
) that, when provided and set toTrue
triggers a browser based authentication instead of basic authentication flow, achieved by passingauthenticator=externalbrowser
as documented here.While there, I needed to:
secure-local-storage
extra tosnowflake-connector-python
to ensure SSO tokens can be cached (documented here)snowflake-connector-python
to latest versionpassword
conditionally optional (only mandatory ifuse_browser_authentication
is notTrue
)Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
x
in the boxes that applyChecklist
setup.py
is an individual PR and not mixed with feature or bugfix PRs[AP-NNNN]
(if applicable. AP-NNNN = JIRA ID)AP-NNN
(if applicable. AP-NNN = JIRA ID)