Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AP-1255] Fixed partial sync if table does not exist in target #1014

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

amofakhar
Copy link
Contributor

Problem

Partial sync was failing if table does not exist in the target

Proposed changes

creating the table in the target if it does not exist

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • [] Relevant documentation is updated including usage instructions

@amofakhar amofakhar temporarily deployed to github-pages September 9, 2022 12:15 Inactive
@amofakhar amofakhar temporarily deployed to ci_tests September 9, 2022 12:15 Inactive
@amofakhar amofakhar temporarily deployed to ci_tests September 9, 2022 15:27 Inactive
@amofakhar amofakhar temporarily deployed to github-pages September 9, 2022 15:27 Inactive
@amofakhar amofakhar merged commit 880b83b into master Sep 9, 2022
@amofakhar amofakhar deleted the AP-1255_table_in_target branch September 9, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants