Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile parameter to avoid Warning #1179

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Makefile parameter to avoid Warning #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/connectors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ jobs:
with:
python-version: '3.8'

- name: Check all connectors are installable
- name: Check PipelineWise and all connectors are installable
run: |
make all_connectors
make pipelinewise_no_test_extras all_connectors
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,21 +79,21 @@ define make_connector
@echo -e "$(OK_MSG)"
@echo -e -n "$(YELLOW)"
@test ! -s $(2)pre_requirements.txt ||\
($(VENV_DIR)/$(1)/bin/pip install --upgrade -r $(2)pre_requirements.txt\
($(VENV_DIR)/$(1)/bin/python3 -m pip install --use-pep517 --upgrade -r $(2)pre_requirements.txt\
&& echo -e "$(RESET_COLOR)"\
&& echo -n "Pre requirements installed..."\
&& echo -e "$(OK_MSG)")
@echo -e -n "$(YELLOW)"
@test ! -s $(2)requirements.txt ||\
($(VENV_DIR)/$(1)/bin/pip install --upgrade -r $(2)requirements.txt\
($(VENV_DIR)/$(1)/bin/python3 -m pip install --use-pep517 --upgrade -r $(2)requirements.txt\
&& echo -e "$(RESET_COLOR)"\
&& echo -n "Requirements installed..."\
&& echo -e "$(OK_MSG)")
@echo -e -n "$(RESET_COLOR)"
@test ! -s $(2)setup.py ||\
(echo "Installing the package..."\
&& echo -e "$(YELLOW)"\
&& $(VENV_DIR)/$(1)/bin/python3 -m pip install --upgrade -e $(2)\
&& $(VENV_DIR)/$(1)/bin/python3 -m pip install --use-pep517 --upgrade -e $(2)\
&& echo -e "$(RESET_COLOR)"\
&& echo -n "Package installation completed..."\
&& echo -e "$(OK_MSG)")
Expand All @@ -114,7 +114,7 @@ define make_pipelinewise
@echo -e -n "$(YELLOW)"
@echo "Installing the package..."
@echo -e "$(YELLOW)"
@$(VENV_DIR)/$(1)/bin/python3 -m pip install --upgrade -e $(2)$(PIP_ARGS)
@$(VENV_DIR)/$(1)/bin/python3 -m pip install --use-pep517 --upgrade -e $(2)$(PIP_ARGS)
@echo -e "$(RESET_COLOR)"
@echo -n "Package installation completed..."
@echo -e "$(OK_MSG)"
Expand Down
Loading