Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ADS team and Add in Contacts Team #46

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

emmajam
Copy link
Contributor

@emmajam emmajam commented Mar 19, 2024

Context

Remove ADS team and Add in Contacts Team

ADS team is no longer, adding in the contacts team

Checklist

@emmajam emmajam requested a review from a team as a code owner March 19, 2024 12:38
@wise-github-bot-app
Copy link

The approval(s) from tanveer-hasan do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, ENGCJT, maps to the ENGINEERING business function. As the code that was changed is owned by PLATFORM, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in PLATFORM. This approval may still help satisfy other codeowner requirements.

@emmajam emmajam merged commit 101ebb8 into master Mar 19, 2024
18 checks passed
@xSeagullx xSeagullx deleted the emmajam-patch-1 branch March 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants